Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable expression templates for time intervals #52335

Merged
merged 3 commits into from Jul 21, 2023
Merged

Disable expression templates for time intervals #52335

merged 3 commits into from Jul 21, 2023

Conversation

tavplubix
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed a crash on inserting data in VALUES format with constant expressions containing INTERVAL operator. Fixes #52026

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Jul 19, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Jul 19, 2023 •
edited

This is an automated comment for commit 3c78e13 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success

@alexey-milovidov alexey-milovidov self-assigned this Jul 19, 2023
@tavplubix
Copy link
Member Author

Many integration tests failed due to a race condition in the CI infrastructure

@tavplubix
Copy link
Member Author

Unit tests (release-clang) - #50423

@tavplubix tavplubix added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jul 21, 2023
@tavplubix tavplubix merged commit b45c2c9 into master Jul 21, 2023
5 of 8 checks passed
@tavplubix tavplubix deleted the fix_values_templates_with_intervals branch July 21, 2023 12:17
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Closed
robot-clickhouse added a commit that referenced this pull request Jul 21, 2023
@robot-clickhouse
Backport #52335 to 22.8: Disable expression templates for time intervals
7c2816b
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jul 21, 2023
@robot-clickhouse
Backport #52335 to 23.3: Disable expression templates for time intervals
58633e0
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jul 21, 2023
@robot-clickhouse
Backport #52335 to 23.4: Disable expression templates for time intervals
676a5c6
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jul 21, 2023
@robot-clickhouse
Backport #52335 to 23.5: Disable expression templates for time intervals
1224442
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Jul 21, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jul 21, 2023
@robot-clickhouse
Backport #52335 to 23.6: Disable expression templates for time intervals
9b83202
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 21, 2023
robot-ch-test-poll4 added a commit that referenced this pull request Jul 21, 2023
@robot-ch-test-poll4
Merge pull request #52425 from ClickHouse/backport/23.4/52335
a419361 
Backport #52335 to 23.4: Disable expression templates for time intervals
tavplubix added a commit that referenced this pull request Jul 24, 2023
@tavplubix
Merge pull request #52427 from ClickHouse/backport/23.5/52335
cdfbda7 
Backport #52335 to 23.5: Disable expression templates for time intervals
tavplubix added a commit that referenced this pull request Jul 24, 2023
@tavplubix
Merge pull request #52423 from ClickHouse/backport/23.3/52335
4eba5cb 
Backport #52335 to 23.3: Disable expression templates for time intervals
alexey-milovidov added a commit that referenced this pull request Jul 25, 2023
@alexey-milovidov
Merge pull request #52429 from ClickHouse/backport/23.6/52335
59a92d8 
Backport #52335 to 23.6: Disable expression templates for time intervals
@Enmk Enmk mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash bug: ClickHouse 23.7.1.857 Server and Client crashed by create table and insert statements
5 participants
@tavplubix @robot-ch-test-poll @alexey-milovidov @robot-ch-test-poll2 @robot-ch-test-poll4