Improve new json functions #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitlibar
force-pushed
the
improve-new-json-functions
branch
4 times, most recently
from
7bd388b
to
b7c2dad
Compare
added 9 commits
May 16, 2019 14:09
vitlibar
force-pushed
the
improve-new-json-functions
branch
from
b7c2dad
to
f494200
Compare
vitlibar
force-pushed
the
improve-new-json-functions
branch
from
5e9c8de
to
85a592e
Compare
vitlibar
force-pushed
the
improve-new-json-functions
branch
from
85a592e
to
ae4f472
Compare
added 5 commits
May 16, 2019 20:40
…(), JSONParser::sizeOfObject().
vitlibar
force-pushed
the
improve-new-json-functions
branch
from
0422175
to
095fc7b
Compare
| static constexpr bool need_preallocate = false; | ||
| void preallocate(size_t) {} | ||
|
|
||
| bool parse(const StringRef &) { throw Exception{"Functions JSON* are not supported without AVX2", ErrorCodes::NOT_IMPLEMENTED}; } |
There was a problem hiding this comment.
TODO check the error message.
alexey-milovidov
approved these changes
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Improved JSON support: added functions
JSONExtractRaw,JSONExtractKeyAndValues, other JSON functions have been slightly changed and optimized.Category:
List of changes:
JSONExtractRaw,JSONExtractKeyAndValues.jsonExtract<type>toJSONExtract<type>. When something goes wrong these functions return the correspondent values, not NULL.JSONExtract, now it gets the return type from its last parameter and doesn't inject nullables.RapidJSONin case AVX2 instructions are not available.simdjsonlibrary updated to a new version.