New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not-ready Set #53162
Merged
Merged
Not-ready Set #53162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Aug 8, 2023
This is an automated comment for commit 93b3069 with description of existing statuses. It's updated for the latest CI running
|
…input ports needed too early in Resize.
KochetovNicolai
added
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
labels
Aug 21, 2023
KochetovNicolai
commented
Aug 21, 2023
Comment on lines
+118
to
+126
|
||
bool DelayedPortsProcessor::shouldSkipDelayed() const | ||
{ | ||
return num_finished_main_inputs + num_delayed_ports < port_pairs.size(); | ||
} | ||
|
||
IProcessor::Status DelayedPortsProcessor::prepare(const PortNumbers & updated_inputs, const PortNumbers & updated_outputs) | ||
{ | ||
bool skip_delayed = (num_finished_pairs + num_delayed_ports) < port_pairs.size(); | ||
bool skip_delayed = shouldSkipDelayed(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the main issue
davenger
approved these changes
Aug 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 21, 2023
robot-clickhouse-ci-1
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Aug 21, 2023
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 22, 2023
Backport #53162 to 23.7: Not-ready Set
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 22, 2023
Backport #53162 to 23.6: Not-ready Set
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 22, 2023
Backport #53162 to 23.5: Not-ready Set
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 22, 2023
Backport #53162 to 23.3: Not-ready Set
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 22, 2023
Backport #53162 to 22.8: Not-ready Set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Not-ready Set is passed as the second argument for function 'in'
could happen with limitedmax_result_rows
andresult_overflow_mode = 'break'