New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back **garbage** dns tests #53286
Bring back **garbage** dns tests #53286
Conversation
…g test_reverse_dns_query
This is an automatic comment. The PR descriptions does not match the template. Please, edit it accordingly. The error is: More than one changelog category specified: 'Build/Testing/Packaging Improvement', 'Three tests were failing / flaky:' |
This is an automated comment for commit 1c3f926 with description of existing statuses. It's updated for the latest CI running
|
@tavplubix @alexey-milovidov I assume the failures are from unrelated garbage? |
@arthurpassos Sure. There was another "garbage" session_log: #51760 I've reverted it in a blink: #53255 But as long as we have some unrelated garbage, pull requests cannot be merged. |
Also, @tavplubix pointed out that we will remove |
…s_coredns_version 23.3 Backport of ClickHouse#53286 - Bring back **garbage** dns tests
…ts_coredns_version 22.8.15 Backport of ClickHouse#53286 - Bring back dns tests
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Three tests were failing / flaky:
Hard coding coredns version to
1.9.3
(latest version of coredns when these tests were introduced) fixed 1 and 2. The latter was failing because we relied on google dns, but that can fail sometimes. To fix this, I simply setup a DNS server for this test as well. It does not rely on 3rd party stuff anymore.Closes #51471
Documentation entry for user-facing changes