Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back **garbage** dns tests #53286

Conversation

arthurpassos
Copy link
Contributor

@arthurpassos arthurpassos commented Aug 10, 2023

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Three tests were failing / flaky:

  1. test_host_regexp_multiple_ptr_records
  2. test_host_regexp_multiple_ptr_records_concurrent
  3. test_reverse_dns_query

Hard coding coredns version to 1.9.3 (latest version of coredns when these tests were introduced) fixed 1 and 2. The latter was failing because we relied on google dns, but that can fail sometimes. To fix this, I simply setup a DNS server for this test as well. It does not rely on 3rd party stuff anymore.

Closes #51471

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@arthurpassos
Copy link
Contributor Author

@clickhouse-ci
Copy link

clickhouse-ci bot commented Aug 10, 2023

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: More than one changelog category specified: 'Build/Testing/Packaging Improvement', 'Three tests were failing / flaky:'

@tavplubix tavplubix added the can be tested Allows running workflows for external contributors label Aug 10, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-build Pull request with build/testing/packaging improvement label Aug 10, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Aug 10, 2023

This is an automated comment for commit 1c3f926 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@clickhouse-ci clickhouse-ci bot added the manual approve Manual approve required to run CI label Aug 10, 2023
@arthurpassos
Copy link
Contributor Author

@tavplubix @alexey-milovidov I assume the failures are from unrelated garbage?

@alexey-milovidov
Copy link
Member

alexey-milovidov commented Aug 11, 2023

@arthurpassos Sure. There was another "garbage" session_log: #51760

I've reverted it in a blink: #53255

But as long as we have some unrelated garbage, pull requests cannot be merged.
It's a requirement - make it 100% clean before merging.

@alexey-milovidov
Copy link
Member

Also, @tavplubix pointed out that we will remove test_tlsv1_3 and test_zookeeper_config.

@alexey-milovidov alexey-milovidov merged commit 0792d36 into ClickHouse:master Aug 12, 2023
266 of 269 checks passed
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Aug 15, 2023
…s_coredns_version

23.3 Backport of ClickHouse#53286 - Bring back **garbage** dns tests
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Aug 18, 2023
…ts_coredns_version

22.8.15 Backport of ClickHouse#53286 - Bring back dns tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors manual approve Manual approve required to run CI pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky integration test_host_regexp_multiple_ptr_records
4 participants