New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect against invalid asynchronous_metrics_update_period_s settings #53428
Merged
rschu1ze
merged 3 commits into
ClickHouse:master
from
rschu1ze:invalid-async-metrics-update-period
Aug 17, 2023
Merged
Protect against invalid asynchronous_metrics_update_period_s settings #53428
rschu1ze
merged 3 commits into
ClickHouse:master
from
rschu1ze:invalid-async-metrics-update-period
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschu1ze
force-pushed
the
invalid-async-metrics-update-period
branch
from
August 14, 2023 18:58
bdacc79
to
3d8f2c3
Compare
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Aug 14, 2023
This is an automated comment for commit 336262f with description of existing statuses. It's updated for the latest CI running
|
alexey-milovidov
approved these changes
Aug 15, 2023
This comment was marked as outdated.
This comment was marked as outdated.
…rics-update-period
robot-ch-test-poll3
added
pr-improvement
Pull request with some product improvements
and removed
pr-bugfix
Pull request with bugfix, not backported by default
labels
Aug 15, 2023
…rics-update-period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trading divide-by-zero crash for a normal exception ...
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Server settings asynchronous_metrics_update_period_s and asynchronous_heavy_metrics_update_period_s configured to 0 now fail gracefully instead of crash the server