Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against invalid asynchronous_metrics_update_period_s settings #53428

Merged
merged 3 commits into from Aug 17, 2023
Merged

Protect against invalid asynchronous_metrics_update_period_s settings #53428

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d8f2c3
Protect against invalid asynchronous_metrics_update_period_s settings
rschu1ze Aug 14, 2023
1986996
Merge remote-tracking branch 'rschu1ze/master' into invalid-async-met…
rschu1ze Aug 15, 2023
336262f
Merge remote-tracking branch 'rschu1ze/master' into invalid-async-met…
rschu1ze Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Interpreters/ServerAsynchronousMetrics.cpp
View file
Open in desktop
Expand Up @@ -24,6 +24,11 @@
namespace DB
{

namespace ErrorCodes
{
extern const int INVALID_SETTING_VALUE;
}

namespace
{

Expand Down Expand Up @@ -52,7 +57,11 @@ ServerAsynchronousMetrics::ServerAsynchronousMetrics(
: AsynchronousMetrics(update_period_seconds, protocol_server_metrics_func_)
, WithContext(global_context_)
, heavy_metric_update_period(heavy_metrics_update_period_seconds)
{}
{
/// sanity check
if (update_period_seconds == 0 || heavy_metrics_update_period_seconds == 0)
throw Exception(ErrorCodes::INVALID_SETTING_VALUE, "Setting asynchronous_metrics_update_period_s and asynchronous_heavy_metrics_update_period_s must not be zero");
}

void ServerAsynchronousMetrics::updateImpl(AsynchronousMetricValues & new_values, TimePoint update_time, TimePoint current_time)
{
Expand Down