New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FINAL
produces invalid read ranges in a rare case
#54934
Merged
nickitat
merged 1 commit into
ClickHouse:master
from
nickitat:final_invalid_read_ranges_bug
Sep 28, 2023
Merged
Fix FINAL
produces invalid read ranges in a rare case
#54934
nickitat
merged 1 commit into
ClickHouse:master
from
nickitat:final_invalid_read_ranges_bug
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickitat
changed the title
Fix final produces invalid read ranges
Fix final produces invalid read ranges in a rare case
Sep 22, 2023
nickitat
force-pushed
the
final_invalid_read_ranges_bug
branch
from
September 22, 2023 18:10
b593dda
to
65bcd8a
Compare
robot-ch-test-poll3
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Sep 22, 2023
This is an automated comment for commit 6241cf4 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
nickitat
changed the title
Fix final produces invalid read ranges in a rare case
Fix Sep 22, 2023
FINAL
produces invalid read ranges in a rare case
nickitat
force-pushed
the
final_invalid_read_ranges_bug
branch
from
September 25, 2023 21:11
65bcd8a
to
6241cf4
Compare
CheSema
approved these changes
Sep 28, 2023
Enmk
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Oct 2, 2023
Fix FINAL produces invalid read ranges in a rare case
Enmk
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Oct 2, 2023
…invalid_read_ranges Backport of ClickHouse#54934 Fix `FINAL` produces invalid read ranges in a rare case
Enmk
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Dec 22, 2023
…produces_invalid_read_ranges 23.8 Backport of ClickHouse#54934 - Fix FINAL produces invalid read ranges in a rare case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed rare bug when we produced invalid read ranges for queries with
FINAL
. Resulted inCannot read out of marks range
exception.Fixes: #54858