New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow drop cache for Protobuf format #55064
Conversation
{ | ||
if (ParserKeyword{"FOR"}.ignore(pos, expected)) | ||
{ | ||
if (ParserKeyword{"Protobuf"}.ignore(pos, expected)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also support for CapnProto, should be easy to add
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be nice to add, but if you do not mind I can add it in the next PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, you can add it in the next PR
This is an automated comment for commit 8d0c961 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
This is an automatic comment. The PR descriptions does not match the template. Please, edit it accordingly. The error is: Changelog entry required for category 'New Feature' |
Please, add small documentation about new system query in system.md file and write a note about this feature in formats.md file in section about Protobuf |
f1fadc3
to
a5ac7e0
Compare
Doesn't seem likely that failed |
@@ -119,6 +119,18 @@ The compiled expression cache is enabled/disabled with the query/user/profile-le | |||
|
|||
Clears the [query cache](../../operations/query-cache.md). | |||
|
|||
## DROP SCHEMA FORMAT CACHE {#system-drop-schema-format} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why you chose order SCHEMA FORMAT CACHE
and not FORMAT SCHEMA CACHE
. The second variant sound more natural for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I wouldn't say I like any of them (there are too many words in the query and it's hard to remember). But comparing them again, I can agree that the second variant might be more natural.
So, yep, I changed it.
Before it was impossible to update Protobuf schema without server restart. With this commit, it is enough to send query `SYSTEM DROP SCHEMA FORMAT CACHE [FOR Protobuf]`.
a5ac7e0
to
8d0c961
Compare
Before it was impossible to update Protobuf schema without a server restart. With this commit, it is enough to send the query
SYSTEM DROP SCHEMA FORMAT CACHE [FOR Protobuf]
.Helpful for
KafkaEngine
andkafka_schema
parameter.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Allow to drop cache for Protobuf format with
SYSTEM DROP SCHEMA FORMAT CACHE [FOR Protobuf]
.Documentation entry for user-facing changes