Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow drop cache for Protobuf format #55064

Merged
merged 1 commit into from Oct 10, 2023

Conversation

AVMusorin
Copy link
Contributor

@AVMusorin AVMusorin commented Sep 27, 2023

Before it was impossible to update Protobuf schema without a server restart. With this commit, it is enough to send the query SYSTEM DROP SCHEMA FORMAT CACHE [FOR Protobuf].

Helpful for KafkaEngine and kafka_schema parameter.

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow to drop cache for Protobuf format with SYSTEM DROP SCHEMA FORMAT CACHE [FOR Protobuf].

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@Avogar Avogar self-assigned this Sep 27, 2023
@Avogar Avogar added the can be tested Allows running workflows for external contributors label Sep 27, 2023
{
if (ParserKeyword{"FOR"}.ignore(pos, expected))
{
if (ParserKeyword{"Protobuf"}.ignore(pos, expected))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also support for CapnProto, should be easy to add

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be nice to add, but if you do not mind I can add it in the next PR?

Copy link
Member

@Avogar Avogar Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, you can add it in the next PR

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Sep 27, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Sep 27, 2023

This is an automated comment for commit 8d0c961 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@clickhouse-ci
Copy link

clickhouse-ci bot commented Sep 28, 2023

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog entry required for category 'New Feature'

@Avogar
Copy link
Member

Avogar commented Sep 28, 2023

Please, add small documentation about new system query in system.md file and write a note about this feature in formats.md file in section about Protobuf

@AVMusorin AVMusorin force-pushed the system-drop-format-cache branch 4 times, most recently from f1fadc3 to a5ac7e0 Compare September 28, 2023 11:34
@AVMusorin
Copy link
Contributor Author

Doesn't seem likely that failed 00385_storage_file_and_clickhouse-local_app_long is related to this PR.

@@ -119,6 +119,18 @@ The compiled expression cache is enabled/disabled with the query/user/profile-le

Clears the [query cache](../../operations/query-cache.md).

## DROP SCHEMA FORMAT CACHE {#system-drop-schema-format}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why you chose order SCHEMA FORMAT CACHE and not FORMAT SCHEMA CACHE. The second variant sound more natural for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I wouldn't say I like any of them (there are too many words in the query and it's hard to remember). But comparing them again, I can agree that the second variant might be more natural.

So, yep, I changed it.

src/Parsers/ASTSystemQuery.h Outdated Show resolved Hide resolved
Before it was impossible to update Protobuf schema without server
restart. With this commit, it is enough to send query `SYSTEM DROP
SCHEMA FORMAT CACHE [FOR Protobuf]`.
@Avogar Avogar merged commit 5ded000 into ClickHouse:master Oct 10, 2023
287 of 288 checks passed
@AVMusorin AVMusorin deleted the system-drop-format-cache branch October 10, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants