New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test to check CapnProto cache #55769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avogar
added
the
can be tested
Allows running workflows for external contributors
label
Oct 18, 2023
robot-ch-test-poll3
added
the
pr-improvement
Pull request with some product improvements
label
Oct 18, 2023
This is an automated comment for commit 9a155ba with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Since current getting schema for CapnProto doesn't use cache, the integration test was for the future if someone add cache. Also, I was curious how schema cache affects performance and I compared reading binary files with Protobuf (I guess it works the same for CapnProto). ``` for i in {1..1000}; do clickhouse-client -q \ "select * from test.simple format Protobuf settings format_schema='/format_schemas/simple:KeyValuePair'" > simple-protobuf${i}.bin; done clickhouse-client --time -q "select * from file('simple-protobuf{1..999}.bin', 'Protobuf') format Null settings format_schema = 'simple:KeyValuePair'" ``` Protobuf with cache and without works with approximately the same time.
AVMusorin
force-pushed
the
capn-proto-drop-cache
branch
from
October 19, 2023 07:16
7ae4b13
to
9a155ba
Compare
AVMusorin
changed the title
[WIP] Allow drop cache for CapnProto format
Added test to check CapnProto cache
Oct 19, 2023
robot-ch-test-poll1
added
pr-not-for-changelog
This PR should not be mentioned in the changelog
and removed
pr-improvement
Pull request with some product improvements
labels
Oct 19, 2023
Failed tests don't look related to the current changes. |
Ah, I forgot we don't have cache for CapnProto schemas :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-not-for-changelog
This PR should not be mentioned in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Since the current schema for CapnProto doesn't use cache, the
integration test was for the future if someone adds a cache.
Also, I was curious how schema cache affects performance and I compared reading binary files
with Protobuf (I guess it works the same for CapnProto).
Protobuf with cache and without works with approximately the same
time.
Follows - #55064
cc @Avogar