New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review #51946 and partially revert it #55336
Conversation
@@ -58,7 +58,7 @@ Connection: Close | |||
Content-Type: text/tab-separated-values; charset=UTF-8 | |||
X-ClickHouse-Server-Display-Name: clickhouse.ru-central1.internal | |||
X-ClickHouse-Query-Id: 5abe861c-239c-467f-b955-8a201abb8b7f | |||
X-ClickHouse-Summary: {"read_rows":"0","read_bytes":"0","written_rows":"0","written_bytes":"0","total_rows_to_read":"0","elapsed_ns":"662334,"peak_memory_usage":"0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here was a syntax error 😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good justification for reverting.
This is an automated comment for commit 972f367 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
I found this SIGSEGV as well (#55280), @alexey-milovidov worth to backport I guess? |
Changelog category (leave one):
Remove peak memory usage from HTTP headers, because the code was suspicious. Most likely it is unneeded.
Fix review comments from #51946. Note: the peak memory usage indication in clickhouse-client remains.