Cherry pick #55336 to 23.8: Review #51946 and partially revert it #55404
Conversation
Review #51946 and partially revert it
robot-ch-test-poll3
added
pr-cherrypick
|
Dear @alexey-milovidov, the PR is not updated for 1d0h50m35s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h0m53s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h0m14s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
@alexey-milovidov any change we could get this merged? |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h56m52s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h1m28s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d1h2m4s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h55m50s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h11m30s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h47m55s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h1m48s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d1h1m53s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h58m3s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h58m18s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
Dear @alexey-milovidov, the PR is not updated for 1d0h0m51s. Please, either resolve the conflicts, or close it to finish the backport process of #55336 |
|
@den-crane, this is an example of why you shouldn't so aggressively insist on merging https://www.linkedin.com/feed/update/urn:li:activity:7090076204552065024/ |
|
@alexey-milovidov I had an impression that you reverted it not because of code quality, but because you did not like the message "Peak memory usage (for query) 128.55 MiB." and the feature itself. That's why I wrote this linkedin message, to attract community attention to the feature that I personally need. |
Original pull-request #55336
This pull-request is a first step of an automated backporting.
It contains changes like after calling a local command
git cherry-pick.If you intend to continue backporting this changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Note
This pull-request will be merged automatically as it reaches the mergeable state, do not merge it manually.
If the PR was closed and then reopened
If it stuck, check #55336 for
pr-backports-createdand delete it if necessary. Manually merging will do nothing, sincepr-backports-createdprevents the original PR #55336 from being processed.If you want to recreate the PR: delete the
pr-cherrypicklabel and delete this branch.You may also need to delete the
pr-backports-createdlabel from the original PR.