Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: storage_metadata_write_full_object_key #55566

Merged
merged 8 commits into from Nov 6, 2023

Conversation

CheSema
Copy link
Member

@CheSema CheSema commented Oct 12, 2023

This is the first step in context of that issue #55217
The second step is #55614

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Introduce the feature storage_metadata_write_full_object_key. If it is set as true then metadata files are written with new format VERSION_FULL_OBJECT_KEY. With that format CH stores full remote object key in the metadata file.

Todo

  • add test S3PlainObjectStorage + storage_metadata_write_full_object_key = true
  • add test MetadataStorageFromStaticFilesWebServer + storage_metadata_write_full_object_key = true

There no implementation for move operation in S3PlainObjectStorage and MetadataStorageFromStaticFilesWebServer. As a result neither Log nor MergeTree tables work on that types of storages.
Instead this tests I did other thing. I turned new flag on here #56027 and checked the tests.

@robot-clickhouse robot-clickhouse added the pr-feature Pull request with new product feature label Oct 12, 2023
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Oct 12, 2023

This is an automated comment for commit 52850d5 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@robot-ch-test-poll3 robot-ch-test-poll3 added pr-improvement Pull request with some product improvements and removed pr-feature Pull request with new product feature labels Oct 12, 2023
@CheSema CheSema force-pushed the remote-blobs-naming branch 5 times, most recently from 4becea7 to a0a8ba6 Compare October 13, 2023 17:24
@CheSema CheSema changed the title [WIP] backward compatibility for template remote keys [WIP] backward compatibility for object storage key template Oct 13, 2023
@CheSema CheSema force-pushed the remote-blobs-naming branch 6 times, most recently from 6b93fb1 to d388ad6 Compare October 17, 2023 10:04
@CheSema CheSema changed the title [WIP] backward compatibility for object storage key template [WIP] backward compatibility for storage_metadata_write_full_object_key Oct 17, 2023
@CheSema CheSema changed the title [WIP] backward compatibility for storage_metadata_write_full_object_key [WIP] feature: storage_metadata_write_full_object_key Oct 17, 2023
@CheSema
Copy link
Member Author

CheSema commented Oct 17, 2023

The C++ code is complete, I think.
There are only several tests left, I dont expect that code is going to change a lot while Im writing them.
So, PR is opened for review.

@CheSema CheSema marked this pull request as ready for review October 17, 2023 16:27
@CheSema CheSema force-pushed the remote-blobs-naming branch 4 times, most recently from 953ff76 to a58d00f Compare October 19, 2023 18:24
@CheSema
Copy link
Member Author

CheSema commented Oct 20, 2023

Stress test (msan) — Sanitizer assert
#55148 (comment)

@CheSema CheSema force-pushed the remote-blobs-naming branch 3 times, most recently from 22ae0d5 to 7c3f985 Compare November 2, 2023 13:18
@CheSema CheSema added the pr-feature Pull request with new product feature label Nov 2, 2023
@robot-ch-test-poll robot-ch-test-poll removed the pr-improvement Pull request with some product improvements label Nov 2, 2023
@CheSema
Copy link
Member Author

CheSema commented Nov 3, 2023

Upgrade check tsan -- #49156

@antonio2368 antonio2368 self-assigned this Nov 3, 2023
src/Common/ObjectStorageKey.cpp Outdated Show resolved Hide resolved
src/Common/ObjectStorageKey.cpp Outdated Show resolved Hide resolved
src/Core/Settings.h Outdated Show resolved Hide resolved
src/Disks/ObjectStorages/DiskObjectStorageMetadata.cpp Outdated Show resolved Hide resolved
src/Disks/ObjectStorages/DiskObjectStorageMetadata.cpp Outdated Show resolved Hide resolved
src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp Outdated Show resolved Hide resolved
src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp Outdated Show resolved Hide resolved
src/Disks/ObjectStorages/DiskObjectStorageTransaction.cpp Outdated Show resolved Hide resolved
CheSema and others added 6 commits November 3, 2023 14:53
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
@CheSema CheSema changed the title [WIP] feature: storage_metadata_write_full_object_key feature: storage_metadata_write_full_object_key Nov 6, 2023
@CheSema CheSema merged commit a5e17dc into ClickHouse:master Nov 6, 2023
279 of 283 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants