New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: storage_metadata_write_full_object_key #55566
Conversation
This is an automated comment for commit 52850d5 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
d30d704
to
ec5ea8d
Compare
4becea7
to
a0a8ba6
Compare
6b93fb1
to
d388ad6
Compare
d388ad6
to
49f7273
Compare
The C++ code is complete, I think. |
953ff76
to
a58d00f
Compare
Stress test (msan) — Sanitizer assert |
22ae0d5
to
7c3f985
Compare
7c3f985
to
825cc93
Compare
…ite_full_object_key
825cc93
to
90b64bc
Compare
Upgrade check tsan -- #49156 |
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
This is the first step in context of that issue #55217
The second step is #55614
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Introduce the feature
storage_metadata_write_full_object_key
. If it is set astrue
then metadata files are written with new format VERSION_FULL_OBJECT_KEY. With that format CH stores full remote object key in the metadata file.Todo
S3PlainObjectStorage
+storage_metadata_write_full_object_key = true
MetadataStorageFromStaticFilesWebServer
+storage_metadata_write_full_object_key = true
There no implementation for move operation in
S3PlainObjectStorage
andMetadataStorageFromStaticFilesWebServer
. As a result neitherLog
norMergeTree
tables work on that types of storages.Instead this tests I did other thing. I turned new flag on here #56027 and checked the tests.