Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] generate object storage key by template #55614

Closed
wants to merge 3 commits into from

Conversation

CheSema
Copy link
Member

@CheSema CheSema commented Oct 13, 2023

This is built on the basis of #55566 as continuation of feature development #55217

Generation path by template is 10% slower (new/old=1.094) then custom function. See the results of gtest::ObjectStorageKey::Performance. Actually I did a good optimization here. It was almost 3 times slower at the begging (new/old=2.8).

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Will fill later

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@CheSema CheSema added the do not test disable testing on pull request label Oct 13, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-feature Pull request with new product feature label Oct 13, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Oct 13, 2023

This is an automated comment for commit cb94d3f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process❌ failure
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@CheSema CheSema force-pushed the remote-blobs-naming-2 branch 6 times, most recently from cf232ed to 39e109d Compare October 16, 2023 23:06
@CheSema CheSema removed the do not test disable testing on pull request label Oct 16, 2023
@CheSema CheSema force-pushed the remote-blobs-naming-2 branch 2 times, most recently from 612cc40 to c2b5b68 Compare October 17, 2023 10:11
@CheSema CheSema changed the title object storage key template generate object storage key by template Oct 17, 2023
@CheSema CheSema force-pushed the remote-blobs-naming-2 branch 3 times, most recently from c3d821c to 929794a Compare October 17, 2023 11:21
@CheSema CheSema changed the title generate object storage key by template [WIP] generate object storage key by template Oct 17, 2023
@CheSema CheSema force-pushed the remote-blobs-naming-2 branch 2 times, most recently from edf5293 to ad20291 Compare October 18, 2023 16:15
@CheSema CheSema force-pushed the remote-blobs-naming-2 branch 5 times, most recently from b341915 to eac07b9 Compare November 7, 2023 12:36
Copy link

clickhouse-ci bot commented Nov 7, 2023

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: More than one changelog category specified: 'Improvement', '### - New Feature'

@CheSema CheSema removed the pr-feature Pull request with new product feature label Nov 7, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-improvement Pull request with some product improvements label Nov 7, 2023
@CheSema CheSema force-pushed the remote-blobs-naming-2 branch 5 times, most recently from 2367cbd to 4b353e8 Compare November 8, 2023 15:03
@CheSema CheSema force-pushed the remote-blobs-naming-2 branch 2 times, most recently from 5c2a0b0 to bb26e91 Compare November 20, 2023 13:48
@CheSema
Copy link
Member Author

CheSema commented Dec 8, 2023

Closed in favour of #57663

@CheSema CheSema closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants