-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] generate object storage key by template #55614
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated comment for commit cb94d3f with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
CheSema
force-pushed
the
remote-blobs-naming-2
branch
6 times, most recently
from
October 16, 2023 23:06
cf232ed
to
39e109d
Compare
CheSema
force-pushed
the
remote-blobs-naming-2
branch
2 times, most recently
from
October 17, 2023 10:11
612cc40
to
c2b5b68
Compare
CheSema
changed the title
object storage key template
generate object storage key by template
Oct 17, 2023
CheSema
force-pushed
the
remote-blobs-naming-2
branch
3 times, most recently
from
October 17, 2023 11:21
c3d821c
to
929794a
Compare
CheSema
changed the title
generate object storage key by template
[WIP] generate object storage key by template
Oct 17, 2023
CheSema
force-pushed
the
remote-blobs-naming-2
branch
from
October 17, 2023 16:10
929794a
to
cb088cf
Compare
CheSema
force-pushed
the
remote-blobs-naming-2
branch
2 times, most recently
from
October 18, 2023 16:15
edf5293
to
ad20291
Compare
CheSema
force-pushed
the
remote-blobs-naming-2
branch
5 times, most recently
from
November 7, 2023 12:36
b341915
to
eac07b9
Compare
This is an automatic comment. The PR descriptions does not match the template. Please, edit it accordingly. The error is: More than one changelog category specified: 'Improvement', '### - New Feature' |
robot-clickhouse-ci-2
added
the
pr-improvement
Pull request with some product improvements
label
Nov 7, 2023
CheSema
force-pushed
the
remote-blobs-naming-2
branch
5 times, most recently
from
November 8, 2023 15:03
2367cbd
to
4b353e8
Compare
CheSema
force-pushed
the
remote-blobs-naming-2
branch
2 times, most recently
from
November 20, 2023 13:48
5c2a0b0
to
bb26e91
Compare
CheSema
force-pushed
the
remote-blobs-naming-2
branch
from
November 20, 2023 14:34
bb26e91
to
d5e6ca5
Compare
1 task
Closed in favour of #57663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on the basis of #55566 as continuation of feature development #55217
Generation path by template is 10% slower (
new/old=1.094
) then custom function. See the results ofgtest::ObjectStorageKey::Performance
. Actually I did a good optimization here. It was almost 3 times slower at the begging (new/old=2.8
).Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Will fill later
Documentation entry for user-facing changes