Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function fromDaysSinceYearZero() #56088

Merged
merged 16 commits into from Nov 3, 2023

Conversation

jh0x
Copy link
Contributor

@jh0x jh0x commented Oct 27, 2023

Closes #55308

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added function fromDaysSinceYearZero() which is similar to MySQL's FROM_DAYS. E.g. SELECT fromDaysSinceYearZero(739136) returns 2023-09-08.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Oct 28, 2023
@jh0x jh0x marked this pull request as ready for review October 31, 2023 19:40
@robot-clickhouse robot-clickhouse added pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR. labels Oct 31, 2023
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Oct 31, 2023

This is an automated comment for commit a43647b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@robot-ch-test-poll2 robot-ch-test-poll2 removed the submodule changed At least one submodule changed in this PR. label Oct 31, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 added the submodule changed At least one submodule changed in this PR. label Oct 31, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 removed the submodule changed At least one submodule changed in this PR. label Oct 31, 2023
@rschu1ze rschu1ze self-assigned this Nov 2, 2023
@rschu1ze rschu1ze changed the title Function fromDaysSinceYearZero Add function fromDaysSinceYearZero() Nov 2, 2023
Reason 1:
- ClickHouse#55696 (comment)
  Basically: Setting `date_time_overflow_behavior` applies only to
  conversions between Date <-> Date32 <-> DateTime <-> DateTime64 but
  it does not control the behavior of functions.

Reason 2:
- It's overkill (even if well-intented overkill). ClickHouse generally
  has a garbage in - garbate out philosophy, so that should be the
  default behavior which corresponds to behavior "ignore". Moreover,
  function 'fromDaysSinceYearZero()' mostly exists for compatibility /
  parity with MySQL and MySQL takes the same stance.
@rschu1ze
Copy link
Member

rschu1ze commented Nov 2, 2023

@jh0x Thanks a lot for this contribution. I took the freedom to make some adjustments (please see my individual commits). The main change is this: 0b587d3 But this is totally not to diminish your effort, you'll be mentioned in the changelog!

@rschu1ze rschu1ze merged commit 480e284 into ClickHouse:master Nov 3, 2023
283 of 284 checks passed
@jh0x jh0x deleted the feature-from-days-zero branch November 4, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide fromDaysSinceYearZero()
5 participants