New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function fromDaysSinceYearZero()
#56088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
added
the
can be tested
Allows running workflows for external contributors
label
Oct 28, 2023
jh0x
force-pushed
the
feature-from-days-zero
branch
from
October 31, 2023 19:40
d8dc6b2
to
f4dc254
Compare
robot-clickhouse
added
pr-feature
Pull request with new product feature
submodule changed
At least one submodule changed in this PR.
labels
Oct 31, 2023
This is an automated comment for commit a43647b with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
robot-ch-test-poll2
removed
the
submodule changed
At least one submodule changed in this PR.
label
Oct 31, 2023
jh0x
force-pushed
the
feature-from-days-zero
branch
from
October 31, 2023 20:49
e853017
to
e7087fe
Compare
robot-ch-test-poll2
added
the
submodule changed
At least one submodule changed in this PR.
label
Oct 31, 2023
jh0x
force-pushed
the
feature-from-days-zero
branch
from
October 31, 2023 21:00
e7087fe
to
e5b4d7f
Compare
robot-ch-test-poll2
removed
the
submodule changed
At least one submodule changed in this PR.
label
Oct 31, 2023
rschu1ze
changed the title
Function fromDaysSinceYearZero
Add function Nov 2, 2023
fromDaysSinceYearZero()
…oDaysSinceYearZero
Reason 1: - ClickHouse#55696 (comment) Basically: Setting `date_time_overflow_behavior` applies only to conversions between Date <-> Date32 <-> DateTime <-> DateTime64 but it does not control the behavior of functions. Reason 2: - It's overkill (even if well-intented overkill). ClickHouse generally has a garbage in - garbate out philosophy, so that should be the default behavior which corresponds to behavior "ignore". Moreover, function 'fromDaysSinceYearZero()' mostly exists for compatibility / parity with MySQL and MySQL takes the same stance.
rschu1ze
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-feature
Pull request with new product feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55308
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added function
fromDaysSinceYearZero()
which is similar to MySQL'sFROM_DAYS
. E.g.SELECT fromDaysSinceYearZero(739136)
returns2023-09-08
.