Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup MIN/MAX for non numeric types #58334

Merged
merged 9 commits into from Jan 4, 2024

Conversation

Algunenano
Copy link
Member

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Speedup MIN/MAX for non numeric types

Documentation entry for user-facing changes

...

Continuation of #58231, bringing some ideas from #40633 but with some extra changes. The idea is:

  • Not null / Not if: Get the column permutation LIMIT 1 and use that. Simple as that. Reuses code, improvements there will improve min/max automagically.
  • Nullable | If: Tested using the permutation (then iterating until the first not null && if found) but it was slower than doing it manually.

In both cases the important part is to avoid copying anything from the block until we know what's the min/max of that block, and only then we compare with the aggregation state. That and removing lots of extra overhead of SingleValueData*.

Because who doesn't want to get max(tuple) 30x faster?

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label Dec 28, 2023
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Dec 28, 2023

This is an automated comment for commit 5bfddfe with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs CheckBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@Avogar Avogar self-assigned this Dec 29, 2023
@Avogar
Copy link
Member

Avogar commented Dec 29, 2023

The code LGTM, but maybe worth adding a performance test that will show the improvement? Don't see any improvements in current performance tests. Also see one test became slower:
Screenshot 2023-12-29 at 16 35 53

@Algunenano
Copy link
Member Author

Few changes:

  • Added perf test for min/max tuple, which is the most common generic type to be used in these functions. The common case is to keep multiple columns from the min row (alternative to doing multiple argMin/argMax with the same sorting column).
  • Renamed findNumeric to findExtreme and the implementation to a .cpp file, so you can depend on it without depending on the implementation.
  • Ignored numeric types from the now default implementation so they keep using the old one. It's likely that we could have a better findExtreme for non native numbers (long integers, Decimals) but this is not the PR to do it.

@Algunenano
Copy link
Member Author

To check:

  • Clang tidy build (need to add a NOLINT to the macro)
  • Check why the perf improvement didn't show. It seems the specific test did not run, but I need to confirm.

@Algunenano
Copy link
Member Author

Finally: image

@Algunenano Algunenano merged commit 0522d85 into ClickHouse:master Jan 4, 2024
260 of 267 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants