Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement system.dns_cache table #59856

Merged
merged 14 commits into from Feb 16, 2024
Merged

Conversation

allmazz
Copy link
Contributor

@allmazz allmazz commented Feb 11, 2024

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Implemented system.dns_cache table, which can be useful for debugging DNS issues

Closes #42690

Example usage: SELECT * FROM system.dns_cache;

hostname ip_address ip_family cached_at
localhost ::1 IPv6 2024-02-11 16:08:16
localhost 127.0.0.1 IPv4 2024-02-11 16:08:16

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2024

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Feb 11, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-feature Pull request with new product feature label Feb 11, 2024
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Feb 11, 2024

This is an automated comment for commit 59c40bc with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@pufit pufit self-assigned this Feb 12, 2024
@alexey-milovidov
Copy link
Member

Please sign a CLA.

@allmazz
Copy link
Contributor Author

allmazz commented Feb 14, 2024

Please sign a CLA.

Done

tests/queries/0_stateless/02981_system_dns_cache_table.sql Outdated Show resolved Hide resolved
src/Storages/System/StorageSystemDNSCache.cpp Outdated Show resolved Hide resolved
docs/en/operations/system-tables/dns_cache.md Outdated Show resolved Hide resolved
src/Common/DNSResolver.cpp Outdated Show resolved Hide resolved
src/Common/DNSResolver.cpp Outdated Show resolved Hide resolved
@pufit pufit merged commit b5ef034 into ClickHouse:master Feb 16, 2024
278 of 283 checks passed
@allmazz allmazz deleted the feature/42690 branch February 16, 2024 19:38
alexey-milovidov added a commit that referenced this pull request Feb 17, 2024
@alexey-milovidov
Copy link
Member

The test has failed. Please resubmit.


- `hostname` ([String](../../sql-reference/data-types/string.md)) — cached hostname
- `ip_address` ([String](../../sql-reference/data-types/string.md)) — ip address for the hostname
- `family` ([String](../../sql-reference/data-types/string.md)) — family of the ip address: `IPv4`, `IPv6`, or `UNIX_LOCAL`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be of type Enum.

Alternatively, replace ip_address by ipv4 (of type Nullable([IP4](https://clickhouse.com/docs/en/sql-reference/data-types/ipv4)), ipv6 (of type Nulalble(IP6)) and unix_local (of type String)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, it's done

@allmazz
Copy link
Contributor Author

allmazz commented Feb 22, 2024

new PR #60257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add system.dns_cache table
6 participants