Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrayReduce with nullable aggregate function name #60188

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

Algunenano
Copy link
Member

@Algunenano Algunenano commented Feb 20, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix arrayReduce with nullable aggregate function name

Documentation entry for user-facing changes

Closes #59600

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Feb 20, 2024
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Feb 20, 2024

This is an automated comment for commit 32130d7 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@Avogar Avogar self-assigned this Feb 20, 2024
@Algunenano
Copy link
Member Author

Need to apply the same for LowCardinality -> SELECT arrayReduce(toLowCardinality('median'), [toLowCardinality(toNullable(8))])

@Algunenano Algunenano merged commit 68a12a5 into ClickHouse:master Feb 21, 2024
198 of 223 checks passed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 21, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 22, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 22, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 23, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 23, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 23, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 24, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 25, 2024
(cherry picked from commit e576f70)
(cherry picked from commit d032fde)
baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 25, 2024
(cherry picked from commit e576f70)
(cherry picked from commit d032fde)
zzcclp pushed a commit to apache/incubator-gluten that referenced this pull request Feb 25, 2024
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240225)

* Add custom target libch to avoid name conflict(due to ClickHouse/ClickHouse#58609)

(cherry picked from commit 0f6281d)
(cherry picked from commit 46c4f8f)

* Revert workaround for fixing bug introduced by ClickHouse/ClickHouse#58886 since ClickHouse/ClickHouse#59911 reverts #58886

(cherry picked from commit 7708bb3)
(cherry picked from commit 4da4f72)

* Fix array_max and array_min due to ClickHouse/ClickHouse#60188

(cherry picked from commit e576f70)
(cherry picked from commit d032fde)

* Fix build CustomStorageMergeTree.h due to ClickHouse/ClickHouse#59531

(cherry picked from commit 666208f)
(cherry picked from commit 60f3415)
(cherry picked from commit f073c5b)

* Fix build CustomStorageMergeTree.cpp due to ClickHouse/ClickHouse#60159

(cherry picked from commit 7cf074a)
(cherry picked from commit a797ba7)

* Fix ActionDAG bug introduced by ClickHouse/ClickHouse#58554

(cherry picked from commit 3432fda)
(cherry picked from commit 066271703498828fa98b31d75bc2dbc27967f78b)
(cherry picked from commit 8d78221)
(cherry picked from commit 3d34c62)

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arrayReduce: Logical error: 'Bad cast from type DB::ColumnVector<double> to DB::ColumnNullable'.
3 participants