-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to override initial INSERT SETTINGS via SYSTEM FLUSH DISTRIBUTED #61832
Conversation
This is an automated comment for commit 35722be with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is much cleaner, better, and easier to understand!
…RIBUTED This is useful to overwrite settings in the initial query during force flush with SYSTEM FLUSH DISTRIBUTED. For example imagine that your server is out of queries (max_max_concurrent_queries_for_all_users had been reached), but you want to flush the distributed table anyway, after this patch you can use something like this: SYSTEM FLUSH DISTRIBUTED dist SETTINGS max_concurrent_queries_for_all_users=1000000 And also fix flush_on_detach for SYSTEM FLUSH DISTRIBUTED, it should ignore flush_on_detach. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
d0cd8d0
to
35722be
Compare
Flaky check found something interesting for the new test, it should be fixed by #61867 |
this PR is better |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add ability to override initial INSERT SETTINGS via SYSTEM FLUSH DISTRIBUTED
This is useful to overwrite settings in the initial query during force flush with SYSTEM FLUSH DISTRIBUTED.
For example imagine that your server is out of queries (max_max_concurrent_queries_for_all_users had been reached), but you want to flush the distributed table anyway, after this patch you can use something like this:
And also fix flush_on_detach for SYSTEM FLUSH DISTRIBUTED, it should ignore flush_on_detach (#53501).
Fixes: #41924