-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arraySymmetricDifference
function
#62262
Conversation
…o calc both intersection and symmetric difference
f.abapolov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Can someone approve my CLA sign?... |
This is an automated comment for commit cdc42b5 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
The extracted part should be also useful for #61553 |
@@ -0,0 +1,548 @@ | |||
#include <Columns/ColumnArray.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment related to this file in general. Please add in strategic places high-level comments what the code/algorithms is doing. For a casual reader, it is almost impossible to follow without tedious debugging to understand what is happening in this file.
(as an example, you could look at src/Functions/array/arrayFold.cpp which I commented recently after a severe bug was found in the initial implementation)
- complex tests with serverErrors - typo in doc fixed - some fixes by comments
This comment was marked as outdated.
This comment was marked as outdated.
…o calc both intersection and symmetric difference
- complex tests with serverErrors - typo in doc fixed - some fixes by comments
This reverts commit 28304a0.
This comment was marked as outdated.
This comment was marked as outdated.
@pheepa GitHub won't let me do that, but unfortunately we need to have the CLA signed. Also, the commit history of this PR is really messy. What about if you squash all your and my commits into a new commit - make sure that Git uses your verified mail address - and force-push (which is generally bad practice but okay in this case)? |
The test failures are related, could you please check them? |
I completely agree, lets drop this one, I will reopen new with fixes and add your commits
I am trying to fix them |
Exported logic from
arrayIntersect
toarrayLogicalFunction
class that covers handling both intersection and symmetric difference. AddedarraySymmetricDifference
function with docs and tests.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added function
arraySymmetricDifference
. This closes: #61673Documentation entry for user-facing changes