Add arraySymmetricDifference function
#64414
Open
+821
−634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
nikitamikhaylov
added
the
can be tested
|
This is an automated comment for commit 87b24ff with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
|
@pheepa It is only a stylistic change but in |
|
@pheepa The AST fuzzer fails. Simplifying the fuzzed query gives this query: select arraySymmetricDifference([CAST('str_', 'Dynamic(max_types = 2)'), 71], [1, 2]) settings allow_experimental_dynamic_type = 1(crash pasted below) "Dynamic" is the new dynamic and experimental data type in ClickHouse. As far as I see, During execution, I guess what we need to do is to wrap the non-dynamic column as dynamic during execution. The crash is because |
|
Thank you a lot! What about code style in 7288c9f, what commit will we keep? |
|
Yeah, the CI makes it not too easy to find an error, and usually one needs to checkout the change, build it, and simplify issue ... |
|
Regarding formatting: Let's go the path of least resistance and go with your reformatting commit. |
|
@pheepa AST Fuzzer failed unfortunately once more (here). The simplified, offending query is: Interestingly, the function parameters for SELECT arrayIntersect([2], [toDecimal64(0., 9)]);
-- Code: 386. DB::Exception: Received from localhost:9000. DB::Exception: There is no subtype for types UInt8, Decimal(18, 9) because some of them are numbers and some of them are not: In scope SELECT arrayIntersect([2], [toDecimal64(0., 9)]). (NO_COMMON_TYPE)Perhaps we also need to disallow Decimal inputs too? (did not check in detail) Another question: is the input data converted to the return type before comparing it? On a related note: It would be great if you could add the crashing (simplified) queries (this one and the previous one) as test cases to 03033_arraySymmetricDifference.sql. |
|
@rschu1ze, Thanks I think Decimal should be supported. In this case we can cast UInt8 to Decimal(18, 9), so the result type will be Decimal(18, 9)
Yes, here I will add these queries to tests, yes |
|
@pheepa It unfortunately looks like FastTest ran into a problem: https://s3.amazonaws.com/clickhouse-test-reports/64414/c4a0be7df4030048c58e31720f442c2f61b2141f/fast_test.html |
|
@pheepa Functional tests are good now (thanks). The problem is that the runtime of existing function It would be great if you could check that too! (use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-does #62262.
Fixes #61673
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added function
arraySymmetricDifferenceDocumentation entry for user-facing changes