[WIP] First small optimisation for z-order curve (a<x and x<b => a<x<b) #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavrolia
changed the title
akuzm
reviewed
Oct 24, 2019
Comment on lines
454
to
455
| if ( | ||
| lhs.function == RPNElement::FUNCTION_IN_RANGE && |
There was a problem hiding this comment.
Let's remove this line break.
|
Can we add some kind of test for this code? |
akuzm
reviewed
Oct 24, 2019
| { | ||
| const size_t to_modify = rpn.size() - 3; | ||
| const auto rhs = rpn[to_modify + 1]; | ||
| const auto lhs = rpn[to_modify]; |
There was a problem hiding this comment.
We can use references here.
Also, let's create a merged element on stack and then put it in rpn if the merge succeeds -- when modifying in place, we can leave some rubbish, especially if some field is added in the future.
akuzm
reviewed
Oct 24, 2019
| lhs.monotonic_functions_chain == rhs.monotonic_functions_chain) | ||
| { | ||
| bool merged = false; | ||
| if (!lhs.range.right_bounded && !rhs.range.left_bounded) |
There was a problem hiding this comment.
Can we just always use Range::intersectRange, or is there some case when this doesn't work?
stavrolia
changed the title
|
Let's continue? |
|
Yep, I would soon |
|
I couldn't reproduce improvement from this optimization and stucked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
First small improvement of KeyCondition.
Category (leave one):