Prohibition secondary index with old syntax merge tree #8822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of https://github.com/millb/ClickHouse into Prohibition_secondary_index_with_old_format_merge_tree
| @@ -1502,6 +1502,13 @@ void MergeTreeData::checkAlterIsPossible(const AlterCommands & commands, const S | |||
| "ALTER MODIFY ORDER BY is not supported for default-partitioned tables created with the old syntax", | |||
| ErrorCodes::BAD_ARGUMENTS); | |||
| } | |||
| if (command.type == AlterCommand::ADD_INDEX && | |||
| format_version < MERGE_TREE_DATA_MIN_FORMAT_VERSION_WITH_CUSTOM_PARTITIONING) | |||
There was a problem hiding this comment.
But why it is different to the previous branch above?
!is_custom_partitioned
… of https://github.com/millb/ClickHouse into Prohibition_secondary_index_with_old_format_merge_tree
alexey-milovidov
approved these changes
Feb 2, 2020
tavplubix
added
pr-bugfix
tavplubix
pushed a commit
that referenced
this pull request
Feb 7, 2020
…old_format_merge_tree Prohibition secondary index with old syntax merge tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Prevent from executing ALTER ADD INDEX for MergeTree tables with old syntax, because it doesn't work.
Detailed description / Documentation draft:
#6889
...
By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.