-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve timezone in arithmetic operations on DateTime #9323
Merged
alexey-milovidov
merged 12 commits into
master
from
datetime-arithmetic-preserve-timezone
Mar 12, 2020
Merged
Preserve timezone in arithmetic operations on DateTime #9323
alexey-milovidov
merged 12 commits into
master
from
datetime-arithmetic-preserve-timezone
Mar 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance test is failed, need to fix. |
Still need to fix two queries in perf test. |
The code is absolutely the same but this PR is up to 10% worse:
|
alexey-milovidov
force-pushed
the
datetime-arithmetic-preserve-timezone
branch
from
March 12, 2020 14:17
3151d01
to
91856dc
Compare
I decided that it's bearable. |
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Mar 16, 2020
KochetovNicolai
pushed a commit
that referenced
this pull request
Mar 16, 2020
…-timezone Preserve timezone in arithmetic operations on DateTime (cherry picked from commit 94dabe3)
KochetovNicolai
pushed a commit
that referenced
this pull request
Mar 16, 2020
…-timezone Preserve timezone in arithmetic operations on DateTime (cherry picked from commit 94dabe3)
KochetovNicolai
pushed a commit
that referenced
this pull request
Mar 16, 2020
…-timezone Preserve timezone in arithmetic operations on DateTime (cherry picked from commit 94dabe3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed the issue: timezone was not preserved if you write a simple arithmetic expression like
time + 1
(in contrast to an expression liketime + INTERVAL 1 SECOND
). This fixes #5743