Generic constructor of ColumnVector from initializer list #9393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-column-vector-initializer-list-constructor
alexey-milovidov
deleted the
better-column-vector-initializer-list-constructor
branch
|
This is wrong. |
alexey-milovidov
added a commit
that referenced
this pull request
Feb 28, 2020
)" This reverts commit 6691302.
|
what's wrong? |
|
Specializations of kudos @Akazz @KochetovNicolai |
|
This can be improved... We just need more specializations. |
|
@alexey-milovidov if it's not urgent, i'm willing to make another pull request. it may take me some time. |
|
Not urgent at all. Yes, it will be appreciated! |
robot-clickhouse
added
the
pr-not-for-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Continuation of #9367