Fix simpliest case of cyclic aliases #9603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
approved these changes
Mar 11, 2020
4ertus2
approved these changes
Mar 11, 2020
| @@ -91,14 +91,21 @@ void QueryNormalizer::visit(ASTIdentifier & node, ASTPtr & ast, Data & data) | |||
| return; | |||
| } | |||
|
|
|||
| /// We are alias for other column (node.name), but we are alias by | |||
There was a problem hiding this comment.
Cannot parse the comment. Are we an alias? Yes, we are. %)
There was a problem hiding this comment.
I also found this comment not clear enough... but still understandable.
Fixed in master. |
Outdated baseline. Actually now it's better. |
KochetovNicolai
pushed a commit
that referenced
this pull request
Mar 16, 2020
Fix simpliest case of cyclic aliases (cherry picked from commit 0d7336c)
vitlibar
pushed a commit
that referenced
this pull request
Mar 26, 2020
Fix simpliest case of cyclic aliases (cherry picked from commit 0d7336c)
vitlibar
pushed a commit
that referenced
this pull request
Mar 26, 2020
Fix simpliest case of cyclic aliases (cherry picked from commit 0d7336c)
vitlibar
pushed a commit
that referenced
this pull request
Mar 27, 2020
Fix simpliest case of cyclic aliases (cherry picked from commit 0d7336c)
vitlibar
pushed a commit
that referenced
this pull request
Mar 27, 2020
Fix simpliest case of cyclic aliases (cherry picked from commit 0d7336c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now it's not possible to create or add columns with simple cyclic aliases like
a DEFAULT b, b DEFAULT a.Relates to #9489