Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't specify default_format parameter #198

Closed
mshustov opened this issue Aug 16, 2023 · 1 comment
Closed

Can't specify default_format parameter #198

mshustov opened this issue Aug 16, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@mshustov
Copy link
Member

database and default_format are special parameters that shouldn't be prefixed with param_.
https://github.com/ClickHouse/ClickHouse/blob/0907623c9dea4600fe4c72a129fe5b7b26d82754/src/Server/HTTPHandler.cpp#L736-L747

clickhouse-js/packages/client-common/src/utils/url.ts

Line 58 in c8f24d7

params.set(`param_${key}`, formatQueryParams(value))

@mshustov mshustov added the good first issue Good for newcomers label Aug 16, 2023
@mshustov mshustov mentioned this issue Sep 1, 2023
Merged
2 tasks
@slvrtrn
Copy link
Contributor

slvrtrn commented Sep 1, 2023

I think #200 closes this.

@mshustov mshustov closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slvrtrn @mshustov