You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit introduces a change that allows for consistent replication between machines, but changes the values of SCCs relative to their prior values. Without this chunk of code, different machines give different results for powers of coefficients, which leads to larger differences in SCCs. This may be related to the fact that np.longdouble returns np.float128 on one machine, and np.longdouble on another. Some kind of changes probably need to be considered to ensure that SCCs run consistently between machines and can be replicated from prior results.
The text was updated successfully, but these errors were encountered:
Hey @JMGilbert. When you have a second, I was curious: In the change you're pointing to in 4adfb60, explicitly casting anomaly to np.float64 appears to solve the issue but do you know what dtype anomaly is when it's not float64 and creating problems?
Just feeling this out without making dramatic changes: An alternative might be to replace those key calls to np.power() with np.float_power() rather than explicitly casting anomaly to float64 at the top of the function. np.float_power() uses at least float64 for the calculation. In contrast, I think np.power() is going to use whatever dtype the first input is by default.
If I wanted to test to see if this or another solution works, what would I need to run? How to replicate the original problem you had? You had to test this on two different machines, as I recall...? This wasn't something that the tests in tests/ picked up on?
This commit introduces a change that allows for consistent replication between machines, but changes the values of SCCs relative to their prior values. Without this chunk of code, different machines give different results for powers of coefficients, which leads to larger differences in SCCs. This may be related to the fact that
np.longdouble
returnsnp.float128
on one machine, andnp.longdouble
on another. Some kind of changes probably need to be considered to ensure that SCCs run consistently between machines and can be replicated from prior results.The text was updated successfully, but these errors were encountered: