Specifically disallow cell ranges for CONCATENATE function. To contra…

…st with CONCAT function
ClosedXML · Apr 1, 2019 · fb28f5c · fb28f5c
1 parent b0eee9e
commit fb28f5c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/ClosedXML/Excel/CalcEngine/Functions/Text.cs b/ClosedXML/Excel/CalcEngine/Functions/Text.cs
@@ -83,6 +83,9 @@ private static object Concatenate(List<Expression> p)
             var sb = new StringBuilder();
             foreach (var x in p)
             {
+                if (x is XObjectExpression objectExpression)
+                    throw new CellValueException("This function does not accept cell ranges as parameters.");
+
                 sb.Append((string)x);
             }
             return sb.ToString();

diff --git a/ClosedXML_Tests/Excel/CalcEngine/TextTests.cs b/ClosedXML_Tests/Excel/CalcEngine/TextTests.cs
@@ -99,6 +99,15 @@ public void Concatenate_Value()
 
             actual = XLWorkbook.EvaluateExpr(@"Concatenate("""", ""123"")");
             Assert.AreEqual("123", actual);
+
+            var ws = new XLWorkbook().AddWorksheet();
+
+            ws.FirstCell().SetValue(20)
+                .CellBelow().SetValue("AB")
+                .CellBelow().SetFormulaA1("=DATE(2019,1,1)")
+                .CellBelow().SetFormulaA1("=CONCATENATE(A1:A3)");
+
+            Assert.Throws<CellValueException>(() => ws.RecalculateAllFormulas());
         }
 
         [Test]
@@ -281,7 +290,6 @@ public void Mid_Value()
             Assert.AreEqual("BC", actual);
         }
 
-
         [TestCase("NUMBERVALUE(\"\")", 0d)]
         [TestCase("NUMBERVALUE(\"1,234.56\", \".\", \",\")", 1234.56d)]
         [TestCase("NUMBERVALUE(\"1.234,56\", \",\", \".\")", 1234.56d)]