WIP Pivot table calculated fields

[igitur]

[work in progress]

Depends on

• Allow pivot tables to have no theme #884
• Implement separate XLSheetviewContentManager #883
• Clear pivot table rendered range upon loading to avoid conflict on re… #856
• Implement the full range of Item subclasses for pivot tables  #904
• Don't choke on pivot table saving when formulas fail #905
• Fix pivot table integrity when saving multiple times. #947
• Consolidated pivot table sources #1039
• Consolidated and refactored pivot sources #1238

First implementation of pivot table calculated fields.

Fixes #821 . Fixes #595 .

TODO:

• Unit tests
• Allow calculated fields to be renamed
• Remove pivot field when calculated field is removed.

[b0bi79]

Wow. You have already begun to implement this, perfectly. Can I help you here?

[igitur]

Thanks, but almost finished. Just need to figure out why sometimes the output file is corrupted.

[igitur]

@b0bi79 I must still add unit tests, but I think most of the pivot table calculated fields are now complete. You're welcome to test this branch and give feedback.

[b0bi79]

Of course, Francois, I already started testing.

[b0bi79]

The generated file does not open in the Excel and when loading ClosedXML an exception occurs.
Here generated file
11.xlsx

[b0bi79]

I think that the calculated fields must be added to PivotCacheDefinition.CacheFields

[igitur]

OK, will fix it.

[b0bi79]

I found. If there are two PivotTables in the workbook that have the same data source, but there is a calculated field in one pivot table, and the other table does not, PivotCacheDefinition.CacheFields may be incorrect.
Applied to the file 11.xlsx:

1. When saving the first PivotTable in PivotCacheDefinition.CacheFields, a list of 8 items was created.
2. When saving the second PivotTable, the PivotCacheDefinition.CacheFields list of 8 elements was replaced by a list of 7 elements

[igitur]

I can't even load that file in Excel.

[b0bi79]

Yes, I too. I created this file with ClosedXML. I added to this file two pivot tables that have one data source. To the first table added calculated field, and to the second table does not.
I found the cause of the error, see my previous comment.

Tomorrow I'll try to write a test that reproduces this issue.

[b0bi79]

Test is very simple. I created one file with Excel . Just opening and saving this file in ClosedXML degrade this file.
tPivot5.xlsx

                using (var wb = new XLWorkbook("tPivot5.xlsx"))
                {
                    wb.SaveAs("d:\\temp\\pvt.xlsx");
                }

I saw what features are inside the xml in this file: the workbook.xml file has only one pivotCache element for all pivot tables in the workbook. ClosedXML on saving replaces pivotCache with invalid data.

[igitur]

@b0bi79 I see now. I think a separate issue to consolidate pivot tables with shared sources should be completed first.

[michaelferry]

@igitur , is this still WIP? Is there a work around in the meantime for me to open spreadsheets with calculated fields in a pivot table?

[Pitterling]

@igitur , is this still WIP? Is there a work around in the meantime for me to open spreadsheets with calculated fields in a pivot table?

facing the same issue, preventing me from using newer ClosedXML version .. Pivot and Calculated Fields have always been in my excel, but now this part is not just skipped .... Thx

[igitur]

Yes, still WIP