Clear pivot table rendered range upon loading to avoid conflict on re… #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igitur
force-pushed
the
issue850-broken-pivot-table
branch
from
da04737
to
0a8cc04
Compare
…ndered cells when opening the file.
igitur
force-pushed
the
issue850-broken-pivot-table
branch
from
0a8cc04
to
4005782
Compare
Pankraty
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850
This PR is a workaround until we have a real pivot table renderer (which is a long way away).
Upon loading a file with an existing pivot table, it clears the range (contents only) of the current pivot table's cells.
Initially I thought to do this only upon saving, but I didn't want to create a situation where ClosedXML reports a cell as having content (that was loaded), but then when it is saved and reopened with ClosedXML the content changes. That's not good.