Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multipart constant names like "Admin::PageHierarchy" #47

Merged
merged 2 commits into from
Mar 23, 2013
Merged

Support multipart constant names like "Admin::PageHierarchy" #47

merged 2 commits into from
Mar 23, 2013

Conversation

fd
Copy link
Contributor

@fd fd commented Mar 13, 2013

No description provided.

@mceachen
Copy link
Collaborator

Thanks for the pull request!

I'd rather us fix the hierarchy_class_name method rather than have
introduce local vars before the hierarchy class creation.

Also, we'll need breaking tests before I can merge.

@fd
Copy link
Contributor Author

fd commented Mar 22, 2013

@mceachen, I had some time to update the PR as you requested.

This is probably the simplest solution I could come up with.

Also I encountered a seemingly unrelated error https://travis-ci.org/mceachen/closure_tree/jobs/5710351

@mceachen
Copy link
Collaborator

Thanks! I'll try to get to it tonight or tomorrow.

@mceachen mceachen merged commit bfa6394 into ClosureTree:master Mar 23, 2013
@fd
Copy link
Contributor Author

fd commented Mar 23, 2013

thanks! great gem btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fd @mceachen