Add demo embedding and addition of logs #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gupta-utkarsh
commented
Aug 22, 2017
gupta-utkarsh
commented
- Add support for demo embedding from origami.
- Add saving of logs for each demo.
- Remove news tab from navbar.
- Direct contribute to section on landing page.
deshraj
reviewed
Aug 25, 2017
apps/logs/views.py
Outdated
| ) | ||
| i += 1 | ||
| except Exception: | ||
| pass |
There was a problem hiding this comment.
@uttu357 can we log the Exception in the logger?
deshraj
requested changes
Aug 25, 2017
apps/logs/views.py
Outdated
| """ | ||
| demo = Demo.objects.get(permalink=demo_permalink) | ||
| if not demo: | ||
| return Response('Unexpected Error', status=status.HTTP_404_NOT_FOUND) |
There was a problem hiding this comment.
Can we please return a dictionary instead of simple text. Something like
{"error": "Demo not found!"} # for error messages
{"message": "Successfully created the demo!"} # for successful messages
gupta-utkarsh
force-pushed
the
demo-embed
branch
from
fe641c2
to
b3d350b
Compare
deshraj
requested changes
Aug 26, 2017
apps/logs/views.py
Outdated
| demo = Demo.objects.get(permalink=demo_permalink) | ||
| if not demo: | ||
| error_message = {'error': 'Demo not found!'} | ||
| return Response(json.dumps(error_message), status=status.HTTP_404_NOT_FOUND) |
There was a problem hiding this comment.
I think that there is no need to do the json.dumps()
apps/logs/views.py
Outdated
| text_type='Output' | ||
| ) | ||
|
|
||
| return Response('OK', status=status.HTTP_200_OK) |
There was a problem hiding this comment.
Please return dict in Response() instead of simple string. Please make this change everywhere in this PR.
gupta-utkarsh
force-pushed
the
demo-embed
branch
from
b3d350b
to
5cd1b5f
Compare
gupta-utkarsh
force-pushed
the
demo-embed
branch
from
5cd1b5f
to
e8b34e1
Compare
|
@deshraj Made the changes. |
deshraj
pushed a commit
that referenced
this pull request
Oct 30, 2017
* CI/CD Setup: Add AWS and Docker scripts (#10) * Backend: Add django models (#11) * Fix docker script and superuser script (#12) * Add Coveralls and Raven Configuration (#13) * fix(docker-compose): Minor change in docker script (#15) * Add Web App API (#14) * feat(api): Add serializers * Add api for contact * feat(contact-api): Add tests * feat(web_team): Add api and tests to retrieve team members * Minor fix * fix(settings): Minor dev settings fix * Settings: Add datadog for logging (#16) * Add middleware for saving request metrics (#17) * fix(datadog): Add middleware for saving request metrics * fix(middleware): Minor style fixes * Add news and showcase frontend (#18) * fix(docker): Fix nodejs docker script (#19) * fix(express): Fix express dist script (#20) - Remove unused socket.io dependency * Fixed padding issues (#24) * Added instructions for non-ssh users in README (#25) * Feat(admin): Add analytics dashboard to django admin (#27) * Add contact us feature (#28) * Add demo embedding and addition of logs (#26) * Minor fix on demo page (#29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.