Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable Error handling #248

Closed
hkmatsumoto opened this issue Jan 3, 2020 · 0 comments
Closed

Unreachable Error handling #248

hkmatsumoto opened this issue Jan 3, 2020 · 0 comments

Comments

@hkmatsumoto
Copy link
Contributor

hkmatsumoto commented Jan 3, 2020

The observed behavior

We have some lines that handles requests.exceptions.MissingSchema, but unfortunately, these lines will be never called because submission_details_request has a except clause for requests.exceptions.RequestException which is a superset of requests.exceptions.MissingSchema.
This means, if a submission has no result, the program shows the unintended error message "Could not establish a connection to EvalAI." instead of the intended error message "The Submission is yet to be evaluated."

The expected behavior

If a submission has no result, the program must show the intended error message "The Submission is yet to be evaluated.".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant