Wrapping an anchor tag around a bookshop tag causes malformed html

[Yoda-Soda]

In the case of wrapping an anchor tag over a bookshop tag the anchor tag gets duplicated on each bookshop generated comment tag. For example:

  {% for card in include.icon_cards %}
      <a href="card.link_url">
          {% bookshop cards/icon-card bind=card %}
      </a>
  {% endfor %}

generates:

<a href="card.link_url">
  <!--bookshop-live name(cards/icon-card/icon-card.jekyll.html) params(bind=card) context(card=icon_cards[0]) -->
</a>
<div class="c-cards-icon-card">
  <a href="card.link_url">
    <div>
        <img />
    </div>
    <header>Title</header>
    <p>Content</p>
    <!--bookshop-live name(generic/link/link.jekyll.html) params(bind=include.link) context() -->
  </a>
<a  href="" >
    Read more
</a>
<!--bookshop-live end-->
</div>

[bglw]

This isn't a bug with Bookshop, and is actually an issue with the nested anchor tags in your example. See Why are nested anchor tags illegal

You could reproduce this same behaviour by dropping the following snippet into a template:

<a href="one">
  <h1>Hello <a href="two">World</a></h1>
</a>