Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting bundlePath option dos not remove console warnings #290

Closed
n-older opened this issue May 2, 2023 · 2 comments
Closed

Setting bundlePath option dos not remove console warnings #290

n-older opened this issue May 2, 2023 · 2 comments
Labels
bug Something isn't working Pagefind Search The web-facing search js/wasm API

Comments

@n-older
Copy link

n-older commented May 2, 2023

I'm trying to hide the console warnings saying that the bundle path could not be resolved based on the javascript import path. The docs say that specifying the bundlePath option for PagefindUI should hide those warnings but it doesn't.

Code:

import { PagefindUI } from '@pagefind/default-ui'; // resolves fine

// inside the `connect` method of a Stimulus controller
this.pagefindUI = new PagefindUI({
  baseUrl: '/',
  bundlePath: '/_pagefind/',
  element: `#${this.elementId}`,
  showImages: false,
  resetStyles: true
});
@bglw bglw added bug Something isn't working Pagefind Search The web-facing search js/wasm API labels May 3, 2023
@bglw
Copy link
Contributor

bglw commented May 3, 2023

Sorry about this — this is a wee bug with the order of load/options for the underlying JS API. I have some plans to fix this for the upcoming Pagefind 1.0 so I'll make sure to test this specific case.

@bglw
Copy link
Contributor

bglw commented Sep 13, 2023

Hey @nolder3193 ! 👋

Good news — this has landed in Pagefind v1.0.0! ✨

See the full release notes here: https://github.com/CloudCannon/pagefind/releases/tag/v1.0.0 💙

@bglw bglw closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Pagefind Search The web-facing search js/wasm API
Projects
None yet
Development

No branches or pull requests

2 participants