-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixed height option(Addresses #270) #326
Conversation
@Cloudef Any update on this? |
Should be ready to merge. |
@Cloudef Any update on this? It's ready, and I've seen discussion about this feature on other issues. |
Please merge, this would be great to have. |
Merged thanks! |
--fixed-height option is only listed in the --help output, seem to be missing from the manpage. |
I completely missed that. You can create a PR about it if you want, as I may not fix this anytime soon. |
Created it :) #344. |
Add a option to make the menu have a fixed height while in vertical mode using
--fixed-height
. This prevents the menu from shrinking or expanding while filtering through items.I modified how the filtered item count is set for the counter(getting the filtered item count directly rather than relying on menu->filtered.count) for the sake of efficiency, and it fixed a bug with the counter in vertical mode.
Closes #270