Add fixed height option(Addresses #270) #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Cloudef Any update on this? |
Cloudef
reviewed
Jan 10, 2023
Cloudef
reviewed
Jan 10, 2023
|
Should be ready to merge. |
|
@Cloudef Any update on this? It's ready, and I've seen discussion about this feature on other issues. |
|
Please merge, this would be great to have. |
|
Merged thanks! |
|
--fixed-height option is only listed in the --help output, seem to be missing from the manpage. |
|
I completely missed that. You can create a PR about it if you want, as I may not fix this anytime soon. |
|
Created it :) #344. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a option to make the menu have a fixed height while in vertical mode using
--fixed-height. This prevents the menu from shrinking or expanding while filtering through items.I modified how the filtered item count is set for the counter(getting the filtered item count directly rather than relying on menu->filtered.count) for the sake of efficiency, and it fixed a bug with the counter in vertical mode.
Closes #270