Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] fixed height #270

Closed
LGFae opened this issue Jun 18, 2022 · 5 comments · Fixed by #326
Closed

[Feature Request] fixed height #270

LGFae opened this issue Jun 18, 2022 · 5 comments · Fixed by #326

Comments

@LGFae
Copy link

LGFae commented Jun 18, 2022

Now that we can spawn bemenu in the center of the screen, it would be useful to have an option that allows for spawning it with a fixed height when using --list.

Currently, I spawn bemenu in the middle of the screen, with 10 lines. As soon as I type something that yields less than 10 results, the whole menu will snap into a new position. This is visually distracting (and doesn't look too good, in my opinion).

@LGFae LGFae changed the title Feature Request: fixed height [Feature Request] fixed height Jun 18, 2022
@merrittlj
Copy link
Contributor

merrittlj commented Dec 27, 2022

currently working on it, most likely will have an option of --fixed-height or -f or something similar.

Cloudef pushed a commit that referenced this issue Feb 18, 2023
* added fixed height option && fixed counter
@stacyharper
Copy link
Contributor

stacyharper commented Feb 21, 2023

@Cloudef I was hopping to implement this today and just discovered you already did some day ago.

I am thinking about the argument:

  • Shouldn't this behavior be the default one when used with -l|--list?
  • Should this behavior be only effective while used centered?

In the current state I would personally add this to my BEMENU_OPTS, but then it would trigger while being used as a top/bottom position (which looks less necessary, and more annoying than usefull).

Do you have some opinion over this?

@stacyharper
Copy link
Contributor

Also another thing I noted: this does not only prevent height changes, it also add blank space if the entries count is lower than the --list value. Maybe what I have in mind is a --list-max instead.

@merrittlj
Copy link
Contributor

merrittlj commented Feb 21, 2023

As the implementer of this, I agree with some of your points. While changing default behavior isn't the best practice, this feature is one sought by many, so I do think it would be ok. However, I feel as it is also appreciated for the top and bottom, but a option for specifying this to only be used on one mode could be useful. Padding the list with blank space itself is not elegant, but it works well, is simple, and does not affect the selection or count of items. If you have a better implementation or want to implement a option, feel free.

@stacyharper
Copy link
Contributor

I agree with your points. Behavior changed but I confess it make the experience more consistent. The menus all take the same size and so you can reliably prepare your next actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants