-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling for exceptions in destinations - fixes #45 #156
Conversation
message = {"hello": 123} | ||
logger.write({"hello": 123}) | ||
self.assertEqual( | ||
messages, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the penny drops! So exceptions raised in failing destinations are logged to the working destinations.
Perhaps it'd be nice to demonstrate that the order of the destinations is unimportant ie failures in destinations further down the list will be logged to working destinations earlier in the destination list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not "working destinations", it's "all destinations".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-read tests, I think coverage implicitly does what you want in later test.
Thanks @itamarst Notes:
Points:
Please address or answer these and the inline comments above and merge when you're satisfied with the build results. |
I will fix two of the issues mentioned above (sphinx theme, versioneer) and then do release when Travis is happy. |
Better handling for exceptions in destinations. Fixes #45.
Fixes #45.