-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eliot-prettyprint no longer dies on non-JSON lines #249
Conversation
try: | ||
message = loads(line) | ||
except ValueError: | ||
stdout.write("(Unparseable JSON, skipping...)\n\n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Print these to stderr and include the failed line (or a snippet of)
Thanks @itamarst Looks good, but I think it should also skip non-eliot JSON lines. e.g. those logged by the docker daemon on journald systems.
Please merge when you've addressed that and added a test for that case. |
eliot-prettyprint no longer dies on non-JSON lines. Fixes #219.
Fixes #219.