Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Use spotlight as an additional way of finding Podfiles #198

Merged
merged 14 commits into from
Jan 17, 2016
Merged

Use spotlight as an additional way of finding Podfiles #198

merged 14 commits into from
Jan 17, 2016

Conversation

orta
Copy link
Member

@orta orta commented Jan 16, 2016

  • Support getting Podfiles from Spotlight
  • Convert them to CPHomeWindowDocumentEntrys
  • Put in a rough tab-like thing to switch between recent / search ( ? )

@orta
Copy link
Member Author

orta commented Jan 16, 2016

OK - come up with a design I'm pretty happy with
screen shot 2016-01-16 at 10 24 23

@orta
Copy link
Member Author

orta commented Jan 16, 2016

screen shot 2016-01-16 at 10 53 42

@orta
Copy link
Member Author

orta commented Jan 16, 2016

screen shot 2016-01-16 at 14 30 32

@orta
Copy link
Member Author

orta commented Jan 16, 2016

When Spotlight is indexing, we show a spinner

screen shot 2016-01-16 at 18 12 25

@orta
Copy link
Member Author

orta commented Jan 16, 2016

If there are no recent documents - and no spotlight documents we show the open podfile panel

screen shot 2016-01-16 at 18 08 09

@orta
Copy link
Member Author

orta commented Jan 17, 2016

screen shot 2016-01-17 at 12 16 42

orta
orta reviewed Jan 17, 2016
View reviewed changes
app/CocoaPods/CPHomeWindowController.m
@@ -179,7 +176,6 @@ - (BOOL)performDragOperation:(id<NSDraggingInfo>)sender
if (fileName != nil) {
NSDocumentController *controller = [NSDocumentController sharedDocumentController];
[controller openDocumentWithContentsOfURL:[NSURL fileURLWithPath:fileName] display:YES completionHandler:^(NSDocument *document, BOOL documentWasAlreadyOpen, NSError *error) {
[self.recentDocumentsController refreshRecentDocuments];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not cached anymore

@orta orta changed the title [WIP] Use spotlight as an additional way of finding Podfiles Use spotlight as an additional way of finding Podfiles Jan 17, 2016
orta added a commit that referenced this pull request Jan 17, 2016
@orta
Merge pull request #198 from CocoaPods/spotlight
3b2559e 
Use spotlight as an additional way of finding Podfiles
@orta orta merged commit 3b2559e into master Jan 17, 2016
@alloy alloy deleted the spotlight branch January 18, 2016 08:55
@orta orta mentioned this pull request Jan 21, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@orta