Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces are not supported in the name of Pods #1610

Closed
fabiopelosin opened this issue Nov 18, 2013 · 7 comments
Closed

Spaces are not supported in the name of Pods #1610

fabiopelosin opened this issue Nov 18, 2013 · 7 comments
Labels
t3:discussion These are issues that can be non-issues, and encompass best practices, or plans for the future.

Comments

@fabiopelosin
Copy link
Member

Pods should not be allowed to include whitespace characters in the names. Currently there is one at least one Pod in the specs repo with a whitespace in the name: Grand Object Dispatch

/c @alloy @Keithbsmiley @orta

@joshkalpin
Copy link
Member

If we decide not to add support for this, I definitely can improve the linter to check for this.

@keith
Copy link
Member

keith commented Nov 18, 2013

Fine with me, no preference really.

@orta
Copy link
Member

orta commented Nov 18, 2013

Yeah, I've dissuaded people from this before. Didn't realise one was in.

@alloy
Copy link
Member

alloy commented Nov 19, 2013

👍

@kylef
Copy link
Contributor

kylef commented Nov 19, 2013

This behaviour is already enforced for pod lib create since caea00d too.

@fabiopelosin
Copy link
Member Author

👍

@joshkalpin
Copy link
Member

Just merged the change into core. Should be able to close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t3:discussion These are issues that can be non-issues, and encompass best practices, or plans for the future.
Projects
None yet
Development

No branches or pull requests

6 participants