-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock the version of the dependencies of the Podfile dependencies #2318
Comments
There is an open issue about this somewhere. However this is cleaner in the description. |
@kylef is this fixed? |
I don't think it is. |
This should have been fixed on master. |
@fabiopelosin in that case, please add a test case to prove that it is, indeed, fixed |
This is indeed not fixed in 0.34.0. $ pod install
Installing Mixpanel 2.5.2 (was 2.5.1) From 0.34.0, installed via |
@kylef any chance you could write an |
The information is correctly stored in the Podfile.lock. It looks like the issue is coming from locking_pods.map do |pod|
lockfile.dependencies_to_lock_pod_named(pod)
end |
Here's steps to reproduce (create the following Podfile and Podfile.lock): platform :ios, '8.0'
pod 'ARAnalytics/Mixpanel'
Run |
@kylef for some reason, when I write a spec, I'm getting |
…cies This test case needs to pass for #2318.
f5701d4 needs to pass in order to close this issue |
@segiddins the goal is to get rid of disabled tests not to introduce new ones. If you have a solution please commit it, otherwise please share insight in a comment. Disabled tests are decoupled from actual implementation might include logical flaws and they are no better than TODOs. Also, please respect the appropriate layer of testing. Unit tests should test the logic of the module (in this case the class) they refer to. The resolver doesn't include any logic for version locking dependencies (by design because this is an unrelated task). To verify the interplay between components I would suggest to use the integration layer. Note: in the past I accepted the PR with the tests related to the optimistic operator even if they are disabled and they are testing a behaviour which is not specifically resolution because you asked for it. However I consider that an exception and I would strongly prefer to keep units tests as noise free as possible. |
@fabiopelosin I pushed the disabled spec because this issue really needs to be fixed. Feel free to remove it / move it wherever you think is best. |
Closed by #2637. |
Example:
$ pod install ... Using GoogleAnalytics-iOS-SDK (3.0.7) ... $ # wait for 3.0.8 to be released $ pod install ... Installing GoogleAnalytics-iOS-SDK 3.0.8 (was 3.0.7) ...
The text was updated successfully, but these errors were encountered: