-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency link #193
Dependency link #193
Conversation
Changes - Now it looks for the podspec on only in the pod root and not in subdirectories as some pods could contains podspecs in an example project folder. - it creates a local pod only for the name provided. This was creating a problem with BlocsKit podspec in the conditional for iOS.
I completely missed your last comment in #178, sorry about that. I’m on the fence about this. I agree with you that live-editing is very important, but I’m thinking that if one would use, for instance, a git submodule in So my suggestion for this is something like: dependency 'MyAwesomeLib', :git => 'GIT URL', :submodule => true This would fetch the lib from the As a matter of fact, this is how I have been doing it since the beginning, but I had to create the submodule manually and then afterwards run |
@kommen, @lukeredpath, @subdigital What do you guys think? |
Ok, I have been overcomplicating this... sorry for the noise. Now I see that a simple However, I have two points which are still unclear:
s/overcomplicating/proposing a stupid solution to/ :-) |
Nothing stupid about it! I should have catched what you were trying to do earlier to save you from this work. Nonetheless, normally I love to discuss patches instead of theories :)
So, personally I add the
Because:
|
Alas, I must admit that my knowledge with regards to the local pod code is not up-to-date yet. @lukeredpath Can you take a look at those changes when you have some time? |
vfrReader - added framework dependencies
My attempt to take full advantage from the workspace feature. It is just an external source that works by making a symbolic link. I tested it a bit and seems to work. But I'm not sure what would happen in edge conditions (e.g. if somebody mixes it with a local pod). As, usual is still missing tests.
Usage
in the podfile:
Previous discussion at #178 - #179.