[#212] Check for deployment target #241
Conversation
| end | ||
| @platform = Platform.new(name, options) | ||
| @platform = Platform.new(name) |
There was a problem hiding this comment.
Is there any reason why @platform should receive the options in a specification. The options are currently used to pass the deployment target, Which is a Gem::Version instead in a specification the deployment target is a Gem::Requirement. This allows to specify deployment targets as:
s.platform = :ios, '>= 5.0'
s.platform = :ios, '~> 5.0'Or something like (for discontinued pods):
s.platform = :ios, ['>= 4.0', '< 6.0']On the other using the Gem:Version would work assuming that the requirement is always >=.
|
I’ll check this out tomorrow. |
|
I'm starting to think that just using the |
|
Oops sorry, I totally forgot to check it. We had queensday on monday, I shouldn't respond to anything on such days :)
Good point, let's just go with that for now. |
* master: [Installer] Don't generate documenation if already installed [Command::Spec::Linter] Fix - Skip documentation generation [Config#doc] Renamed to generate_docs [Command::Spec::Linter] Bug fix. [# 242 Command::Spec::Linter] Refactoring [#246 | Resolver] Validate plaforms against each target. [Resolver] Check target plafroms instead of podfile. Conflicts: lib/cocoapods/resolver.rb
- Allow to specify the deployment target after initialization
Nothing to be sorry about :-) Queensday looks like a really nice event! |
| @@ -8,22 +8,29 @@ def self.osx | |||
| new :osx | |||
| end | |||
|
|
|||
| attr_reader :options | |||
| attr_reader :options, :deployment_target | |||
There was a problem hiding this comment.
I think that the options attribute could be removed because it is not currently used.
ghost
assigned 
|
Looks all good to me. Were there any specific questions you still wanted answered that I might have missed? Btw, regarding setting up the feeds server, I will try to get to that tomorrow, it’s been a hectic week :) |
Cool, I'm merging.
Great :-)
Indeed... |
[#212] Check for deployment target
New Version of NXOAuth2Client
[#212] Check for deployment target
Going throughout pull request because I'm not sure of some points.