[Resolver] Allow platform detection to work for nested dependencies #4097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -532,7 +532,7 @@ def resolve_dependencies | |||
| end | |||
|
|
|||
| specs_by_target = nil | |||
| UI.section "Resolving dependencies of #{UI.path podfile.defined_in_file}" do | |||
| UI.section "Resolving dependencies of #{UI.path(podfile.defined_in_file) || 'Podfile'}" do | |||
There was a problem hiding this comment.
This change seems unrelated? Also, shouldn't podfile.defined_in_file always have a value?
There was a problem hiding this comment.
(Which is what prompted this PR, so I made that change whilst debugging)
segiddins
force-pushed
the
seg-resolver-platforms-fix
branch
from
9d9de86
to
5a2784e
Compare
|
Please review @kylef , this should be mergable. |
|
Good, but it needs to be 🍏 green. |
|
Will be green once #4104 (comment) is merged |
segiddins
force-pushed
the
seg-resolver-platforms-fix
branch
from
5a2784e
to
36f96d4
Compare
segiddins
added a commit
that referenced
this pull request
Sep 2, 2015
[Resolver] Allow platform detection to work for nested dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4084.