[FileReferencesInstaller] Dont create build headers for frameworks #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you please summarize what the original issue was, how and why this PR solves the problem? |
|
The issue is that the search paths were being added to the headers directory in addition to the file references in the project, causing duplicates and Xcode to complain that there were non module includes taking place. |
|
LGTM 👍 |
segiddins
force-pushed
the
seg-no-framework-build-headers
branch
from
5da90f1
to
6fb0bfa
Compare
|
Will merge when green |
|
|
segiddins
added a commit
that referenced
this pull request
Nov 13, 2015
[FileReferencesInstaller] Dont create build headers for frameworks
This was referenced Dec 11, 2015
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4420 .
\c @neonichu @mtitolo