Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileReferencesInstaller] Add build headers #4848

Closed
wants to merge 2 commits into from

Conversation

mrackwitz
Copy link
Member

Built frameworks require still private and build headers to be linked in the pod target support files' header directory.

Built frameworks require still private and build headers to be linked in the pod target support files' header directory.
@segiddins
Copy link
Member

This basically reverts #4476 -- please verify this isn't a regression for the linked-to issue

@mrackwitz
Copy link
Member Author

Oh right, thanks for the reference again. I’ll try to properly reproduce the original issue but with the latest Xcode version.

@neonichu
Copy link
Member

neonichu commented Feb 2, 2016

Just for context as the original issue is very long: this was due to a change in swiftc, so make sure to test with a Swift project.

@mrackwitz
Copy link
Member Author

@neonichu: Good point, saw that as well. But I think I could reproduce it already independent from swiftc 😕, given that podspecs should never need to define CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES=YES itself as some concerned podspecs (FBSDKCoreKit, etc.) do that. If I remove it manually from the xcconfig, they break with this change. If I remove the HEADER_SEARCH_PATHS, then they build again.

@segiddins segiddins added this to the 1.0.0 milestone Feb 7, 2016
@segiddins
Copy link
Member

@mrackwitz this'll need a rebase before merging

@segiddins
Copy link
Member

@mrackwitz is this still something that needs to happen?

@mrackwitz
Copy link
Member Author

No, it seems like this would be a regression.

@mrackwitz mrackwitz closed this Feb 23, 2016
@mrackwitz mrackwitz deleted the mr-fix-header-search-paths branch February 23, 2016 12:52
@reduxdj
Copy link

reduxdj commented Mar 17, 2016

CocoaPods 1.0.0.beta.6 is available.
To update use: gem install cocoapods --pre
[!] This is a test version we'd love you to try

Yep I tried and I still can't get the realm library to work.
Can you give me some guidance please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants