[Rubocop] Use a .rubocop-cocoapods.yml config file common to all CP repos

[AliSoftware]

As discussed in CocoaPods/cocoapods-plugins#17 (specifically here)

Trying to split the rubocop rules to have rules specific to CocoaPods/Core separated to rules that should be common to all CP repos, like CocoaPods/CocoaPods but also CP plugins.
This way we could have every CP repo inherit_from the same .rubocop-cocoapods.yml and then only throw their specific rules

/c @dbgrandi @irrationalfab

[AliSoftware]

Unfortunately I didn't find a way to move this spec/fixtures/** exclusion to .rubocop-cocoapods.yml because as soon as we give a new value to the AllCops/Exclude/ YAML key the whole key is overriden (meaning that there is no concat between the AllCops/Exclude/ inherited array and the one here, but just a plain replacement).

Open for ideas on this case.

[AliSoftware]

Maybe adding a pattern like lib/**/vendor/** for the AllCops/Exclude key in .rubocop-cocoapods.yml would work and do what we expect from this exclusion?
So that we could remove this key from the repo-specific .rubocop.yml config file and avoid the problem?

[fabiopelosin]

I plan to remove the vendor stuff so I won't bother too much about it.

[AliSoftware]

Side note: Maybe we could use this occasion to change the Rakefile integration too, and do as suggested in rubocop's README here instead of using Rubocop::CLI.new?

require 'rubocop/rake_task'
Rubocop::RakeTask.new do |task|
  task.fail_on_error = true
end

[AliSoftware]

Reminder: also take https://github.com/CocoaPods/trunk.cocoapods.org/blob/master/.rubocop.yml into account when we build the .rubocop-cocoapods.yml common file
/c @alloy

[fabiopelosin]

Side note: Maybe we could use this occasion to change the Rakefile integration too, and do as suggested in rubocop's README here instead of using Rubocop::CLI.new?

👍

[fabiopelosin]

We should have a place where to store the canonical .rubocop-cocoapods.yml file and add a rake task to update it.

Ace work!

[AliSoftware]

We should have a place where to store the canonical .rubocop-cocoapods.yml file and add a rake task to update it.

Great idea. Where should be put it? Having a dedicated repo for this seems overkill, so maybe use the one from CocoaPods/Core here as a reference for all others?
And then make the rake task do some curl https://raw.githubusercontent.com/CocoaPods/Core/master/.rubocop-cocoapods.yml -o .rubocop-cocoapods.yml (for all repos except CocoaPods/Core of course)?

[fabiopelosin]

Great idea, the reference should be in CocoaPods/CocoaPods imo, and the rake task should be added to Rainforest (as it is common).

[AliSoftware]

Ok then I will let you guys do it, as I am not familiar with the Rainforest environment yet and how to do this in a clean way without breaking it all 😉

[fabiopelosin]

👍