Default subspecs

[kylef]

🍻

[houndci-bot]

Line is too long. [81/80]

[fabiopelosin]

The singular form should continue working in a similar fashion to the other DSL attributes.

[fabiopelosin]

I.e. just drop the deprecation. Ace work btw!

[kylef]

@irrationalfab What should happen if you set both default_subspecs and default_subspec? Simply dropping 11445bc should be fine yes?

[fabiopelosin]

The behaviour of the rest of the attributes when they are redeclared (a misuse of the DSL) is to replace the value.

The patch looks really good, but it should be coherent with the rest of the attributes logic:

• The :singularize property for the : default_subspec should be used.
• The :container property should be set to Array

[fabiopelosin]

Yeah almost all of the 11445bc should be dropped. Note that Specification::Consumer takes care of boxing the raw value of the in the container if needed.

I don't recall the reason why this is being done during the read instead of during the writing (which if I recall correctly used to be the case in the past). I need to recheck and change if appropriate, this might be relevant to the JSON conversion.

/c @alloy

[kylef]

Thanks for the pointers @irrationalfab.

I'm trying to implement this now, however the boxing mechanism isn't working as I expected. My attribute looks like the following:

attribute :default_subspecs, :container => Array, :singularize => true, :multi_platform => false

Now, spec.default_subspec = 'Pod' is resulting in spec.default_subspecs to be equal to Pod and not an array containing Pod. Am I doing this correctly?

[fabiopelosin]

Now, spec.default_subspec = 'Pod' is resulting in spec.default_subspecs to be equal to Pod and not an array containing Pod. Am I doing this correctly?

I don't recall if there is an exact reason for this (I refactored the Specification class so many times, consider it a strange hobby), but to get the boxing and all the rest of the logic the Specification::Consumer should be used (which at the moment is lacking the support for the default subspec, maybe because it was not needed and because it is not multi-platform).

So to get the boxing something like specification.consumer(platform).default_subspecs should be used. Subspecs like all the other attributes make practical sense only in the context of a platform. Although this might look inconvenient for the time being I would use it and consider a refactor after.

[houndci-bot]

Line is too long. [85/80]

[kylef]

Alright thanks for going over that. I noticed that there were no tests for the other singularised attributes in the way I was doing them. So i've removed these tests and updated the pull request.

Take a look and tell me if there's anything else to add 👍.

[kylef]

Thanks for the support on this one @irrationalfab 👍.

[fabiopelosin]

Ace!