Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist Pods by build configuration #154

Merged
merged 17 commits into from
Aug 12, 2014
Merged

Conversation

fabiopelosin
Copy link
Member

No description provided.

nevyn-lookback and others added 13 commits December 12, 2013 15:36
An option to only link a specific pod to the target when building in a specific configuration.
The exact syntax is still TBD, pending discussion in CocoaPods/CocoaPods#1668
which implements the corresponding functionality.
An option to only link a specific pod to the target when building in a specific configuration.
The exact syntax is still TBD, pending discussion in CocoaPods/CocoaPods#1668
which implements the corresponding functionality.
…ck-pods-by-config

* 'pods-by-config' of github.com:lookback/Core:
  [pod] whitelisting: code style and specs
  [pod] Whitelist pods for configurations

Conflicts:
	lib/cocoapods-core/podfile/target_definition.rb
	spec/podfile/target_definition_spec.rb
# for any configuration, it is implicitly whitelisted.
#
# @param [String] pod_name
# The pod that we're querying about inclusion for in the given configuration.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [91/80]

end

it 'enables pods for configurations they are whitelisted for' do
@root.store_pod('ObjectiveSugar', :configuration => 'Release')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


it 'allows to white-list a dependency on a build configuration' do
podfile = Podfile.new do
pod 'PonyDebugger', :configuration => 'Release'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the new Ruby 1.9 hash syntax.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@fabiopelosin
Copy link
Member Author

Handling the build configurations insensitively is necessary because CocoaPods names the xcconfig after them and OS X ships with a case insensitive file system.

/c @orta @alloy

@fabiopelosin fabiopelosin self-assigned this Aug 11, 2014
@fabiopelosin fabiopelosin merged commit a2f2d24 into master Aug 12, 2014
@mrackwitz mrackwitz deleted the lookback-pods-by-config-2 branch August 16, 2015 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants